[PATCH] x32: Add <asm/unistd_x32.h> and regenerate arch-syscall.h

Florian Weimer fweimer@redhat.com
Mon Aug 24 19:10:17 GMT 2020


* H. J. Lu:

> Since __NR_set_thread_area may not be defined in the kernel header file,
> move the test to tests-internal doesn't solve the problem.

I expect that internal tests use the built-in system call tables, so
<fixup-asm-unistd.h> should be effective for them (indirectly, after
regenerating the tables).

>> But is it really correct to add an unsupported system call definition
>> for the rest of glibc?  If this is just setting things up for a test,
>> maybe the __X32_SYSCALL_BIT hack is the right approach after all.
>> (I don't know the objective of this test.)
>
> set_thread_area is supported on x32.  The only thing missing is
>
> #define __NR_set_thread_area (__X32_SYSCALL_BIT + 205)
>
> in <asm/unistd_x32.h>.
>
> Should I update my original patch to
>
> #define __NR_set_thread_area (__X32_SYSCALL_BIT + 205)

But set_thread_area is not supported for application use, so it's an
internal/whitebox test no matter what.

What exactly are you trying to test?

Thanks,
Florian



More information about the Libc-alpha mailing list