[PATCH 3/5] signal: Move sys_errlist to a compat symbol

Joseph Myers joseph@codesourcery.com
Tue Apr 28 14:54:05 GMT 2020


On Mon, 27 Apr 2020, Adhemerval Zanella via Libc-alpha wrote:

> The symbol is deprecated by strsignal and its usage imposes some issues
> such as copy relocations.
> 
> Its internal names is changed to _sys_errlist_internal to avoid static
> linking usage. The compat code is also refactored by removing the over
> enginered errlist-compat.c generation from manual entried. It
> disantangle the code generation from manual and simplify both Linux and
> Hurd compat code (no more scatter definition on both manual and linker
> scripts).

If we remove this generation from the manual, then I think it needs to be 
replaced with a test that fails if an error number is added to the errno 
tables without being documented in the manual.  (Ideally we'd similarly 
check that errno.h and the errno table have the same set of values listed, 
but consistency between the manual and the errno table is what the present 
scripts should achieve and thus what should be maintained when removing 
the scripts.)

I'd guess that this change means the "val" argument to the @errno macro in 
the manual can be removed.  In any case, the comment on that macro 
definition needs updating.

Also, at least scripts/update-copyrights and scripts/build-many-glibcs.py 
have lists of generated files that need updating for this one no longer 
being generated.

> +* The deprecated sys_errlist, _sys_errlist, sys_nerr, and _sys_nerr arrays
> +  are non longer available to newly linked binaries, and their declarations

sys_nerr and _sys_nerr aren't arrays.

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list