[COMMITTED] localedef: Add verbose messages for failure paths.

Szabolcs Nagy szabolcs.nagy@arm.com
Mon Apr 27 15:22:44 GMT 2020


The 04/27/2020 10:28, Carlos O'Donell wrote:
> On 4/27/20 7:52 AM, Szabolcs Nagy wrote:
> > 
> > locale/tst-localedef-path-norm consistently times out on the aarch64 buildbot.
> > 
> > is it ok to commit the attached fixup?
> 
> I'm OK with upgrading the test case timeout to 25s.
> 
> Florian does not agree with me, and would like to see if he can change
> the charmap used to iso-88591-15 instead of UTF-8 (which is a large charmap)
> and still get coverage of the same code.
> 
> The reason I used UTF-8 is because it tests the normalization code that
> converts UTF-8 to utf8 (lowercase and drop dash). Which is also achieved by
> iso-88591-15.
> 
> I think Florian can follow up with another patch to change the test case to
> use iso-88591-15 and lower the timeout.
> 
> In the meantime I'm going to approve your fix to unblock your builders.

ok, i committed the patch as is for now.


More information about the Libc-alpha mailing list