[PATCH] misc: Turn sstk into a compat symbol

Florian Weimer fw@deneb.enyo.de
Mon Apr 27 12:52:35 GMT 2020


* Zack Weinberg:

> On Mon, Apr 27, 2020 at 7:01 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> It is not implemented anywhere.  There is an osf_sstk system call on
>> alpha, but it is not used to implement sstk, and the system call
>> is not implemented on Linux, either.
>
> Maybe you should also remove the entry for sstk from
> sysdeps/unix/syscalls.list?

Indeed, and I also forgot to add attribute_compat_text_section.

8<------------------------------------------------------------------8<
Subject: misc: Remove sstk from the autogenerated system call list
    
This change should not have an effect because the system call was
never defined.  Also add the misssing attribute_compat_text_section
attribute to the sstk function (a minor optimization).

Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
("misc: Turn sstk into a compat symbol").

diff --git a/misc/sstk.c b/misc/sstk.c
index 0a2a967917..dda6f7b426 100644
--- a/misc/sstk.c
+++ b/misc/sstk.c
@@ -19,7 +19,7 @@
 #include <shlib-compat.h>
 
 #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_32)
-void *
+void * attribute_compat_text_section
 sstk (int increment)
 {
   __set_errno (ENOSYS);
diff --git a/sysdeps/unix/syscalls.list b/sysdeps/unix/syscalls.list
index 01c4a0e6b1..e8f8718b04 100644
--- a/sysdeps/unix/syscalls.list
+++ b/sysdeps/unix/syscalls.list
@@ -78,7 +78,6 @@ sigaction	-	sigaction	i:ipp	__sigaction	sigaction
 sigsuspend	-	sigsuspend	Ci:p	sigsuspend
 socket		-	socket		i:iii	__socket	socket
 socketpair	-	socketpair	i:iiif	socketpair
-sstk		-	sstk		b:i	sstk
 statfs		-	statfs		i:sp	__statfs	statfs
 swapoff		-	swapoff		i:s	swapoff
 swapon		-	swapon		i:s	swapon


More information about the Libc-alpha mailing list