[PATCH 02/10] linux: Simplify opendir buffer allocation
Florian Weimer
fw@deneb.enyo.de
Fri Apr 24 13:08:20 GMT 2020
* Adhemerval Zanella:
> On 24/04/2020 07:11, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>>> This looks okay to me. I wonder if we should just use 32 KiB
>>>> uncodintionally, though?
>>>
>>> Do you mean instead of '4 * BUFSIZ'?
>>
>> Yes. I assumed BUFSIZ was 8192.
>>
>
> Alright, I can make this change. Any opinion whether we should keep
> 32 KiB or increase/decrease it?
Sorry, I think it should be a separate change. Lowering the buffer
size will unfortunately expose application bugs when applications
modify the directory while iterating through it using readdir. (musl
sees more such bugs due to its smaller buffer size.)
More information about the Libc-alpha
mailing list