[PATCH] elf: Remove redundant add_to_global_resize_failure call from dl_open_args
Florian Weimer
fw@deneb.enyo.de
Fri Apr 24 10:55:39 GMT 2020
The second call does not do anything because the data structures have
already been resized by the call that comes before the demarcation
point. Fixes commit a509eb117fac1d764b15eba64993f4bdb63d7f3c
("Avoid late dlopen failure due to scope, TLS slotinfo updates
[BZ #25112]").
-----
Tested on i686-linux-gnu and x86_64-linux-gnu.
elf/dl-open.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/elf/dl-open.c b/elf/dl-open.c
index 7b3b177aa6..d9fdb0bdce 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -738,11 +738,6 @@ dl_open_worker (void *a)
DL_STATIC_INIT (new);
#endif
- /* Perform the necessary allocations for adding new global objects
- to the global scope below, via add_to_global_update. */
- if (mode & RTLD_GLOBAL)
- add_to_global_resize (new);
-
/* Run the initializer functions of new objects. Temporarily
disable the exception handler, so that lazy binding failures are
fatal. */
More information about the Libc-alpha
mailing list