[PATCH glibc 2/9] Move elf/elf_machine_sym_no_match.h to sysdeps/generic

Carlos O'Donell carlos@redhat.com
Wed Apr 22 16:27:52 GMT 2020


On 3/26/20 11:56 AM, Mathieu Desnoyers wrote:
> sysdeps/generic/elf_machine_sym_no_match.h matches
> sysdeps/mips/elf_machine_sym_no_match.h better.
> 
> Suggested-by: H.J. Lu <hjl.tools@gmail.com>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Florian Weimer <fweimer@redhat.com>
> ---
>  {elf => sysdeps/generic}/elf_machine_sym_no_match.h | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {elf => sysdeps/generic}/elf_machine_sym_no_match.h (100%)
> 
> diff --git a/elf/elf_machine_sym_no_match.h b/sysdeps/generic/elf_machine_sym_no_match.h
> similarity index 100%
> rename from elf/elf_machine_sym_no_match.h
> rename to sysdeps/generic/elf_machine_sym_no_match.h
> 

Moving the file to sysdeps/generic is fine, it has
nothing to do with a machine, and it does cleanup
the generic elf/ directory a bit. It also allows
sysdep/ override to be a bit clearer in intent.

This needs to be squashed with the original commit
which creates elf_machine_sym_no_match.h.

This patch incorporates HJs feedback.

This patch on its own is not OK.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list