[PATCH v4 14/21] nptl: m68k: Fix Race conditions in pthread cancellation [BZ#12683]

Adhemerval Zanella adhemerval.zanella@linaro.org
Tue Apr 7 12:46:43 GMT 2020



On 03/04/2020 18:34, Andreas Schwab wrote:
> On Apr 03 2020, Adhemerval Zanella via Libc-alpha wrote:
> 
>> +ENTRY (__syscall_cancel_arch)
>> +#ifdef __mcoldfire__
>> +	lea	(-16,%sp),%sp
>> +	movem.l	#60,(%sp)
>> +#else
>> +	movem.l	#15360,-(%sp)
>> +#endif
> 
> Please use register names.
> 
>> +#ifdef __mcoldfire__
>> +	movem.l	(%sp),#60
>> +	lea	(16,%sp),%sp
>> +#else
>> +	movem.l	(%sp)+,#60
>> +#endif
> 
> Likewise.
> 
> Andreas.
> 

Ack.


More information about the Libc-alpha mailing list