"make check" times

Joseph Myers joseph@codesourcery.com
Wed Apr 1 23:01:15 GMT 2020


On Wed, 1 Apr 2020, Carlos O'Donell via Libc-alpha wrote:

> On 4/1/20 3:58 PM, DJ Delorie via Libc-alpha wrote:
> > 
> > Andreas Schwab <schwab@linux-m68k.org> writes:
> >> Never expand a variable unquoted.
> > 
> > How's this?  Also, comment updated to note we assume "echo" is a
> > builtin.
> > 
> 
> LGTM. All variable expansions quoted. Non-builtins removed for performance.
> Comment added to explain what we're doing.

Strictly speaking a safe "read" would be IFS= read -r line (IFS= to avoid 
stripping leading whitespace, -r to avoid backslash escapes being 
processed).  However, in this case that's not needed because valid test 
result lines do not start with whitespace and do not contain backslash 
(and nor do they start -n or -e, being cases where the "echo" would be 
unsafe).

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list