[PATCH] Fix alignment bug in Safe-Linking

Carlos O'Donell carlos@redhat.com
Wed Apr 1 01:55:24 GMT 2020


On 3/31/20 2:13 AM, Eyal Itkin wrote:
> Attached now is the 2nd patch that only handles the bugfix for 32 bit
> binaries, and should go on top of the 1st patch for the indentation
> and CR fixes from you and Andreas.
> 
> Passes all tests on my 32 bit environment and 64 bit environment.

I retested this on 64-bit and 32-bit and it also passes my tests.

I've pushed this to master.

I admit I hadn't noticed the misaligned_chunk vs. aligned_OK differences,
but you are correct. The tcache does operate on the memory directly (this
is because the memory is considered in-use by the thread), while the
rest of the checks should use misaligned_chunk (operate directly on chunk).

Thanks for working through this.

We'll sync Fedora Rawhide and retest (Thanks DJ!)

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list