[PATCH 2/2] time: Add padding for the timespec if required

Joseph Myers joseph@codesourcery.com
Wed Sep 25 00:57:00 GMT 2019


On Tue, 24 Sep 2019, Alistair Francis wrote:

> +#if __WORDSIZE == 64 \
> +  || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) || \
> +  __TIMESIZE == 32

|| goes at start of line, not at end of line.

>    __syscall_slong_t tv_nsec;	/* Nanoseconds.  */
> +#else
> +# if __BYTE_ORDER == __BIG_ENDIAN
> +  int: 32;           /* Padding */
> +  long int tv_nsec;  /* Nanoseconds */
> +# else
> +  long int tv_nsec;  /* Nanoseconds */
> +  int: 32;           /* Padding */
> +# endif
> +#endif

The comment formatting in the other cases, with ".  " ('.' and two spaces) 
at end of comment, is correct GNU style.

The patch is OK with those fixes once the <bits/endian.h> changes are 
reviewed and checked in.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list