[PATCH] math: Remove const attribute from totalorder* functions

Joseph Myers joseph@codesourcery.com
Thu Sep 5 15:23:00 GMT 2019


On Thu, 5 Sep 2019, Gabriel F. T. Gomes wrote:

> On Thu, 05 Sep 2019, Gabriel F. T. Gomes wrote:
> 
> >On Wed, 04 Sep 2019, Joseph Myers wrote:
> >
> >>This is OK, but it would be better to replace it with __attribute_pure__ 
>                                                         ~~~~~~~~~~~~~~~~~~
> Oh! Only upon reading my own reply, I noticed the suggestion to use this
> macro, instead of __attribute__ ((__pure__)).  Should I go ahead and patch
> it again...
> 
> >+__MATHDECL_1 (int, totalorder,, (const _Mdouble_ *__x,
> >+				 const _Mdouble_ *__y))
> >+     __attribute__ ((__pure__));
> 
> ... replacing '__attribute__ ((__pure__))' with '__attribute_pure__'?

I think it should use __attribute_pure__, yes (although quite likely using 
the older compilers for which they differ would show up other problems 
with current glibc headers).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list