[RFC v5 01/21] sunrpc/clnt_udp: Ensure total_deadline is initalised

[Joseph Myers]

On Thu, 5 Sep 2019, Jeff Law wrote:

> BTW, has a bug been filed against GCC for the bogus warning?

In this case, it looks like the code is

  if (xargs != NULL)
    {
       total_deadline = ...
    }

  ...

  if (xargs != NULL)
    {
      use total_deadline
    }

(and xargs doesn't get modified in the function and the various gotos in 
this function are all after that setting of total_deadline).  So that 
should be a known issue (and we could consider if the existing comment

  /* Choose the timeout value.  For non-sending usage (xargs == NULL),
     the total deadline does not matter, only cu->cu_wait is used
     below.  */

is sufficient or should be extended to say explicitly the warning is 
bogus).

-- 
Joseph S. Myers
joseph@codesourcery.com