[RFC v5 01/21] sunrpc/clnt_udp: Ensure total_deadline is initalised

[Alistair Francis]

On Thu, Aug 29, 2019 at 10:34 AM Zack Weinberg <zackw@panix.com> wrote:
>
> On Thu, Aug 29, 2019 at 1:22 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > On Thu, 29 Aug 2019, Alistair Francis wrote:
> >The long pole is definitely the ml2014 build environment, unless for some reason we need the new version of pip first? I don't actually know.  I'm assu
> > > Even though total_deadline won't be accessed uninitalised GCC can still
> > > complain that it is accessed unitalised, to avod those errors let's make
> > > sure we initalise it to 0.
> >
> > It's glibc practice (although missing from
> > <https://sourceware.org/glibc/wiki/Style_and_Conventions>) that we *don't*
> > add initializations like that to avoid warnings.
>
> Although this has historically been glibc practice, I think it is
> unwisely incautious, and we should change the policy to be that we
> *do* add initializations whenever the compiler thinks a variable even
> _might_ be used uninitialized.

Does that mean this patch is ok?

Alistair

>
> zw