[review v3] localedef: Add verbose messages for failure paths.
Joseph Myers
joseph@codesourcery.com
Fri Oct 25 14:56:00 GMT 2019
On Fri, 25 Oct 2019, Carlos O'Donell (Code Review) wrote:
> https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/1/locale/programs/localedef.c@531
> PS1, Line 531: _("failed to allocate space for compiled locale path"));
> > I think this line is too long. [â¦]
> Done
This is a meta-comment on the formatting of these emails and a test of
email replies to gerrit:
"PS1, Line 531:" is not helpful, and just makes the lines in these
messages longer. Quoted text should just use normal "> " to quote it
(with the additional leading character "+", "-" or " " when being quoted
as part of a diff hunk).
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list