[PATCH 2/2] elf: Use nocancel pread64() instead of lseek()+read()
Florian Weimer
fweimer@redhat.com
Thu Oct 24 13:46:00 GMT 2019
* Carlos O'Donell:
>>>> emacs logs/glibcs/i686-gnu/004-glibcs-i686-gnu-build-log.txt
>>>
>>> Thanks. I didn't see this. Let me start another build.
>>
>> I think I know what's going on and I'm looking to a fix.
>>
>> We shouldn't let such build regressions linger for so long.
>
> Sorry, you are right 4 days is too long. It speaks again for pre-commit
> CI since even straight forward things can have consequences like this.
> I ran b-m-g and didn't see this, but perhaps I made a mistake. At least
> twice I've botched the glibc branch checkout and tested b-m-g against
> upstream instead of upstream+patch.
>
> You and I have spoken about this off list and you have a patch, so I'm
> going to leave this with you to fix while I go review the CodeSourcery/Mentor
> patches.
I posted a patch:
<https://sourceware.org/ml/libc-alpha/2019-10/msg00706.html>
Thanks,
Florian
More information about the Libc-alpha
mailing list