[PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.

Alistair Francis alistair23@gmail.com
Wed Oct 2 18:27:00 GMT 2019


On Wed, Oct 2, 2019 at 9:30 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> This appears to have broken the testsuite for all platforms.  How was it
> tested?

Argh, I ran the tests on the wrong thing.

>
> FAIL: conform/POSIX2008/arpa/inet.h/conform
> FAIL: conform/POSIX2008/netdb.h/conform
> FAIL: conform/POSIX2008/netinet/in.h/conform
> FAIL: conform/UNIX98/arpa/inet.h/conform
> FAIL: conform/UNIX98/netdb.h/conform
> FAIL: conform/UNIX98/netinet/in.h/conform
> FAIL: conform/XOPEN2K/arpa/inet.h/conform
> FAIL: conform/XOPEN2K/netdb.h/conform
> FAIL: conform/XOPEN2K/netinet/in.h/conform
> FAIL: conform/XOPEN2K8/arpa/inet.h/conform
> FAIL: conform/XOPEN2K8/netdb.h/conform
> FAIL: conform/XOPEN2K8/netinet/in.h/conform
> FAIL: conform/XPG42/arpa/inet.h/conform
> FAIL: conform/XPG42/netdb.h/conform
> FAIL: conform/XPG42/netinet/in.h/conform
>
> By keeping <endian.h> in networking headers, while removing __USE_MISC
> conditionals from that header, it introduces namespace violations to the
> networking headers in all standards modes.  You'll need to restore the
> __USE_MISC conditionals in <endian.h>.

I just sent the patch, it fixes the failures. Sorry about the regression

Alistair

>
> --
> Joseph S. Myers
> joseph@codesourcery.com



More information about the Libc-alpha mailing list