[PATCH] mips: Do not include hi and lo in __SYSCALL_CLOBBERS for R6
Joseph Myers
joseph@codesourcery.com
Tue Nov 19 16:57:00 GMT 2019
On Tue, 19 Nov 2019, Dragan Mladjenovic wrote:
> From: "Dragan Mladjenovic" <dmladjenovic@wavecomp.com>
>
> GCC 10 (PR 91233) won't silently allow registers that are not architecturally
> available to be present in the clobber list anymore, resulting in build failure
> for mips*r6 targets in form of:
> ...
> .../sysdep.h:146:2: error: the register âloâ cannot be clobbered in âasmâ for the current target
> 146 | __asm__ volatile ( \
> | ^~~~~~~
>
> This is because base R6 ISA doesn't define hi and lo registers w/o DSP
> extension. This patch provides the alternative definitions of
> __SYSCALL_CLOBBERS for r6 targets that won't include those registers.
What is the kernel ABI on r6 systems with the DSP extension - does the
kernel ABI permit the kernel to clobber those registers on syscall return
or not? This patch looks like it's only safe if the kernel guarantees it
will never clobber those registers on r6 (or later), regardless of
instruction set extensions present.
Also, this issue suggests that build-many-glibcs.py ought to include MIPS
r6 configurations to detect such build issues. It might not be a good
idea to duplicate all 24 ABIs for r6 (I don't know how many of them make
sense for r6 anyway), but at least one each of o32, n32 and n64 for r6 (if
all those make sense for r6) would be a good idea. (build-many-glibcs.py
additions should be a separate patch.)
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list