For the practical sake of the gerrit experiment --- Don't change the commit message.

Florian Weimer fw@deneb.enyo.de
Sat Nov 16 14:42:00 GMT 2019


* Carlos O'Donell:

> Florian,
>
> I think from a practical stand point we don't need to record
> the Reviewed-by: lines for the reviews done in Gerrit.
>
> Lets just pretend that they would get added in the future.
> This way we can focus on what the real workflow would be like.
>
> This way if you get at +2 in Gerrit just assume you can push
> without all the other work.
>
> Does this sound OK to you?

Fine with me.  It reduces mailing list clutter because a patch
approval does results only in +2 and pushed notification, not +2, new
version, +2 again, push, so a net reduction by two messages.



More information about the Libc-alpha mailing list