[PATCH v2 15/30] ldbl-128ibm-compat: Add syslog functions

Paul E Murphy murphyp@linux.ibm.com
Thu Nov 14 17:47:00 GMT 2019



On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
> 
> Changes since v1:
> 
>    - Moved the test to a container, which stopped messages being written
>      to the system log.
> 
> Comment from v1:
> 
> I'm using 'syslog (LOG_DEBUG, etc.);' and support_capture_subprocess in
> the test case, which I believe will not print to the console, but I'm
> not sure if changing some system setting to high verbosity will disturb
> people's lives.  Please advise.  :)
> 
> -- 8< --
> Similarly to __vfprintf_internal and __vfscanf_internal, the internal
> implementation of syslog functions (__vsyslog_internal) takes a
> 'mode_flags' parameter used to select the format of long double
> parameters.  This patch adds variants of the syslog functions that set
> 'mode_flags' to PRINTF_LDBL_USES_FLOAT128, thus enabling the correct
> printing of long double values on powerpc64le, when long double has IEEE
> binary128 format (-mabi=ieeelongdouble).
> 
> Tested for powerpc64le.

glibc has containers these days, neat. This looks OK to me and addresses 
the feedback from v1.



More information about the Libc-alpha mailing list