How to keep Reviewed-by lines in git commits with gerrit.

Carlos O'Donell carlos@redhat.com
Tue Nov 12 21:09:00 GMT 2019


On 11/12/19 3:57 PM, Florian Weimer wrote:
> * Carlos O'Donell:
>> In general I see 3rd parties as my manager doing a review of what work
>> I'm doing upstream. People not involved in the project directly.
> 
> Well yes, but that's internal Red Hat politics. 8-p

If we see these politics, I expect others see them also, but worse.

My goal as a steward would be to look for win-win situations where
I can both satisfy a corporate demand to review work being done,
and at the project level thank those reviewers.

I think we are in rough agreement here that if gerrit can add the
reviewed-by lines then that's what we want.

We can turn it on experimentally.

I think we *will* have to give the instances a way to push without
a shell account, and I'm not sure how to do that.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list