How to keep Reviewed-by lines in git commits with gerrit.

Florian Weimer fw@deneb.enyo.de
Tue Nov 12 20:02:00 GMT 2019


* Jonathan Nieder:

>>> I would prefer it to be automatically added by the review tool, as
>>> gerrit is designed to do.
>>
>> Is it?
>
> The Cherry Pick and Rebase Always submit strategies[1] automatically
> add Reviewed-by footers.
>
> Other submit strategies (like Merge If Necessary) are designed to not
> touch the change uploader's commit (e.g. they may have signed it) so
> they don't add the footer.

> [1]
> https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies

I'm confused.  Is it expected that these changes are not visible in
the commits I can download (under the DOWNLOAD button) or in the web
UI?  Are they added only during the push?



More information about the Libc-alpha mailing list