[PATCH] malloc: fix compile error
liqingqing
liqingqing3@huawei.com
Fri Nov 1 07:48:00 GMT 2019
ping again
On 2019/10/31 11:44, liqingqing wrote:
>>> I think you can give more details about the error like the compile
>>> step. and so that the other guys may get more information.
>>>
>>
>> Agreed. The commit message should say which error and which compiler
>> version generated the error.
>>
>> We still can't accept patches from Huawei yet because copyright
>> assignment
>> has not been completed. But thanks for the review!
>>
>
> hello Carlos, how are you?
> we found that other people which is from Huawei also have the same
> problem. below is the discussion.
> https://sourceware.org/ml/libc-alpha/2019-10/msg00905.html
>
> we checked the contribution checklist again, and we also have the same
> question: even if we just fix a bug in the situation that we has already
> completed an fsp copyright assignment, the code also can not be
> accepted?  what we need to do next? we expect your or others more
> helps, thank you.
>
hello carlos, I checked the contribution checklist again and i think
maybe it has two different situations. the FSF copy assignment section
said that only "legally signification" required copyright assigment.
here is the copy:
"The Free Software Foundation (holder of the glibc copyrights) requires
copyright assignment for all legally significant changes by a particular
author (read not a company). This webpage describes the copyright
assignment requirements."
and the legally signification changes is defined like that:
http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant
section 6.2 Legally Significant Changes :
"If a person contributes more than around 15 lines of code and/or text
that is legally significant for copyright purposes, we need copyright
papers for that contribution, as described above.
A change of just a few lines (less than 15 or so) is not legally
significant for copyright. A regular series of repeated changes, such as
renaming a symbol, is not legally significant even if the symbol has to
be renamed in many places. Keep in mind, however, that a series of minor
changes by the same person can add up to a significant contribution.
What counts is the total contribution of the person; it is irrelevant
which parts of it were contributed when."
so I think for few changes like a bugfix, the patche can be accepted.
and for "legally significant changes" , we also need your help: what is
possible contribute ways? a public huawei account which is approved by
the supervisor? or an huawei's public copyright assignment?
can you give me more suggestions? thank you.
liqingqing
More information about the Libc-alpha
mailing list