[PATCH 08/28] powerpc: generic nearbyint/nearbyintf

Gabriel F. T. Gomes gabriel@inconstante.eti.br
Mon May 27 20:42:00 GMT 2019


On Fri, Mar 29 2019, Adhemerval Zanella wrote:
>
> 	* sysdeps/powerpc/fpu/round_to_integer.h (set_fenv_mode): Add
> 	NEARBYINT handling.
> 	* sysdeps/powerpc/fpu/s_nearbyint.c: New file.
> 	* sysdeps/powerpc/fpu/s_nearbyintf.c: Likewise.
> 	* sysdeps/powerpc/powerpc32/fpu/s_nearbyint.S: Remove file.
> 	* sysdeps/powerpc/powerpc32/fpu/s_nearbyintf.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/s_nearbyint.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/s_nearbyintf.S: Likewise.

OK.

> +  case NEARBYINT:
> +    /*  Disable FE_INEXACT exception  */
> +    reset_fpscr_bit (FPSCR_XE);
> +    break;

OK.  Do not change round direction and disable the inexact exception.

> -	mffs	fp11
> -	mtfsb0	4*cr7+lt	/* Disable FE_INEXACT exception */

OK. Behaviour copied to the C implementation.

Looks good to me, thanks.



More information about the Libc-alpha mailing list