[glibc] sysvipc: Consolidate semtimedop s390

Adhemerval Zanella adhemerval.zanella@linaro.org
Tue May 21 11:30:00 GMT 2019



> Il giorno 21 mag 2019, alle ore 03:30, Florian Weimer <fweimer@redhat.com> ha scritto:
> 
> * Adhemerval Zanella:
> 
>> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=236c18e5683028d41c2721a8b1ec45c56c953d95
>> 
>> commit 236c18e5683028d41c2721a8b1ec45c56c953d95
>> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> Date:   Wed May 15 10:23:49 2019 -0300
>> 
>>    sysvipc: Consolidate semtimedop s390
>> 
>>    This patch consolidates the s390-32 semtimedop implementation by defining
>>    a arch-specific SEMTIMEDOP_IPC_ARGS to rearrange the arguments expected
>>    by s390 Linux kABI.  The idea is to avoid have multiples semtimedop
>>    implementation changes for Linux v5.1 change to enable wire-up sysvipc
>>    support.
>> 
>>    Checked with a s390-linux-gnu and s390x-linux-gnu and checking that
>>    resulting semtimedop objects did not change.
>> 
>>        * sysdeps/unix/sysv/linux/ipc_priv.h (SEMTIMEDOP_IPC_ARGS): New
>>        define.
>>        * sysdpes/unix/sysv/linux/s390/ipc_priv.h: New file.
>>        * sysdeps/unix/sysv/linux/s390/semtimedop.c: Remove file.
>>        * sysdeps/unix/sysv/linux/semtimedop.c (semtimedop): Use
>>        SEMTIMEDOP_IPC_ARGS for calls with __NR_ipc.
> 
> This seems to have caused
> 
> ../sysdeps/unix/sysv/linux/semtimedop.c: In function ‘semtimedop’:
> ../sysdeps/unix/sysv/linux/semtimedop.c:34:10: error: implicit declaration of function ‘SEMTIMEDOP_IPC_ARGS’ [-Werror=implicit-function-declaration]
>          SEMTIMEDOP_IPC_ARGS (nsops, sops, timeout));
>          ^~~~~~~~~~~~~~~~~~~
> 
> on powerpc-linux-gnu (and some others).
> 
> I'm not sure how this is supposed to work, given that ipc_priv.h has
> sysdeps overrides and only the gneric and s390 were updated in this
> commit.
> 
> Thanks,
> Florian

Indeed, I though I have done a rebuild on all abi to avoid such failures, but it does not seems the case I will ha dele it.


More information about the Libc-alpha mailing list