glibc git commit hooks update.

Joseph Myers joseph@codesourcery.com
Thu May 16 19:35:00 GMT 2019


On Wed, 17 Apr 2019, Carlos O'Donell wrote:

> > One problem with the old hooks was that they did not generate a
> > Content-Type header, which was unhelpful when the mails also weren't pure
> > ASCII.  I see the new ones are generating 'Content-Type: text/plain;
> > charset="us-ascii"'.  Will they also be smart about specifying an
> > appropriate character set (so UTF-8 if the commit message / author name /
> > diff contents are valid UTF-8 but not ASCII, for example)?
> 
> All of this is handled by python's email package and some handling
> on the hooks part. If everything is ASCII then we don't do any special
> encoding and just send ASCII. Otherwise we choose UTF-8 first and if
> that fails a decode test then we fallback to ISO-8859-1.

This does not seem to be working as intended.  See e.g. 
https://sourceware.org/ml/glibc-cvs/2019-q2/msg00147.html (UTF-8 bytes 
marked as us-ascii, so ’ appears as â??, for example).

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list