[PATCH] Respect CPPFLAGS when generating stdio-lim.h

Palmer Dabbelt palmer@sifive.com
Mon Mar 18 11:53:00 GMT 2019


On Mon, 18 Mar 2019 04:47:47 PDT (-0700), schwab@suse.de wrote:
> On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>
>>    I'm checking via build-many-glibc.py to make sure this builds, but as
>>    that never sets CPPFLAGS I don't think it'll find any potential issues.
>
> Since CPPFLAGS is always set by our makefiles I don't understand this
> comment.

My point is that bulid-many-glibcs.py isn't adding any additional CPPFLAGS, so 
we wouldn't notice anything that might crop up because of how users (who 
may have set some odd CPPFLAGS) build their glibc.

Maybe that's being too paranoid, though?



More information about the Libc-alpha mailing list