[PATCH] Linux: Use mmap instead of malloc in dirent/tst-getdents64

Florian Weimer fweimer@redhat.com
Fri Jun 28 14:52:00 GMT 2019


* Adhemerval Zanella:

> Alright, but my point is for usual 64-bit architecture (which the test
> are actually exercised) mapping 4GB of memory shouldn't really be a
> problem.

Our z/VM guests have 2 GiB RAM assigned to them.

> The change looks ok, I would just like to make is more explicit
> that the tests passed, but not all sub-tests ran.

It's just a warning, not FAIL_UNSUPPORTED:

      if (large_buffer == MAP_FAILED)
        printf ("warning: could not allocate %zu bytes of memory,"
                " subtests skipped\n", large_buffer_size);

If you don't like that, we'd have to split it into a separate test, I
think.

Thanks,
Florian



More information about the Libc-alpha mailing list