[PATCH] Fix build warnings in resolv/res_send.c
Stefan Liebler
stli@linux.ibm.com
Tue Jun 25 13:18:00 GMT 2019
Hi,
this patch fixes the gcc warnings seen with gcc 9 -march>=z13 on s390x:
res_send.c: In function â__res_context_sendâ:
res_send.c:498:7: error: âresplenâ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
498 | if (n == 0 && (buf2 == NULL || *resplen2 == 0))
| ^
In this case send_vc is inlined into __res_context_send
and the maybe uninitialized resplen belongs to the one in send_vc.
In send_vc there is already a DIAG_IGNORE_NEEDS_COMMENT (5,
"-Wmaybe-uninitialized")
and a comment which explains that this is a false-positive.
Note that resplen is used as return value.
This patch adds a further DIAG_IGNORE_NEEDS_COMMENT around the
declaration of n
in __res_context_send and the comparison after n was set to the return
value of send_vc.
Bye
Stefan
ChangeLog:
* resolv/res_send.c (__res_context_send):
Disable maybe-uninitialized warning.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20190625_warnings_resolv_res_send_disablewarning.patch
Type: text/x-patch
Size: 2632 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20190625/00ed73e9/attachment.bin>
More information about the Libc-alpha
mailing list