[PATCH v4 05/11] nds32: Generic <math.h>, soft-fp and hard-fp Routines

[Joseph Myers]

On Wed, 5 Jun 2019, Vincent Chen wrote:

> +double __ieee754_sqrt (double x)

Example of a coding style issue, should have the function name in a 
definition at the start of a new line (separate line from return type).  
This only applies in definitions, not in function declarations that are 
not definitions.  Please fix everywhere in the patch series.

> +  if (__KERNEL_SUPPORT_SUBNOR_OUTPUT) {

Example of a coding style issue, '{' should go on its own line, indented 
two columns from the line above (and then the contents of the block should 
be indented a further two columns).

> diff --git a/sysdeps/nds32/fpu/fenv_private.h b/sysdeps/nds32/fpu/fenv_private.h
> new file mode 100644
> index 0000000..45c13f6
> --- /dev/null
> +++ b/sysdeps/nds32/fpu/fenv_private.h

> +#ifndef NDS32_MATH_PRIVATE_H
> +#define NDS32_MATH_PRIVATE_H 1

That seems an inappropriate macro name for a fenv_private.h header.

-- 
Joseph S. Myers
joseph@codesourcery.com