[Patch v3] MIPS support for GNU hash

Carlos O'Donell carlos@redhat.com
Wed Jul 24 21:09:00 GMT 2019


On 7/24/19 8:17 AM, Adhemerval Zanella wrote:
> 
> 
> On 23/07/2019 09:44, Mihailo Stojanovic wrote:
>> Hello everyone,
>>
>>    This patch is a reimplementation of [1], which was submitted back in
>> 2015. Copyright issue has been sorted out [2] last year. It proposed a
>> new section (.gnu.xhash) and related dynamic tag (DT_GNU_XHASH). The new
>> section would be virtually identical to the existing .gnu.hash except
>> for the translation table (xlat) which would contain correct MIPS
>> .dynsym indexes corresponding to the hashvals in chains. This is because
>> MIPS ABI imposes a different ordering of the dynyms than the one
>> expected by the .gnu.hash section. Another addition would be a leading
>> word which would contain the number of entries in the translation table.

...

  
> LGTM, however Carlos has the final word whether it is up for 2.30.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

I'm not happy without the binutils pieces being committed.

I'd like to see this get committed in binutils, start to get used,
sorted out properly, wrinkles removed, and then final glibc pieces
put into place so we don't advance further mistakes in an official
release.

I'm removing this from the blocker list.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list