[PATCH] test-container: Install with $(all-subdirs) [BZ #24794]

Tulio Magno Quites Machado Filho tuliom@linux.ibm.com
Tue Jul 23 16:29:00 GMT 2019


DJ Delorie <dj@redhat.com> writes:

> Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> writes:
>> Whenever a sub-make is created, it inherits the variable subdirs from its
>> parent.  This is also true when make check is called with a restricted
>> list of subdirs.  In this scenario, make install is executed "partially"
>> and testroot.pristine ends up with an incomplete installation.
>
> "obvious in retrospect"  Sigh.
>
>> 2019-07-22  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
>>
>> 	[BZ #24794]
>> 	* Makefile (testroot.pristine/install.stamp): Pass
>> 	subdirs='$(all-subdirs)' to make install.
>
> LGTM.  Thanks!
>
> Reviewed-by: DJ Delorie <dj@redhat.com>

Pushed as 35e038c1d2ccb.

Thanks!

-- 
Tulio Magno



More information about the Libc-alpha mailing list