[PATCH] test-container: Avoid copying unintended system libraries

Tulio Magno Quites Machado Filho tuliom@linux.ibm.com
Tue Jul 23 16:26:00 GMT 2019


Florian Weimer <fw@deneb.enyo.de> writes:

> * Tulio Magno Quites Machado Filho:
>
>> Some DSOs are distributed in hardware capability directories, e.g.
>> /usr/lib64/power7/libc.so.6
>> Whenever the processor is able to use one of these hardware-enabled
>> DSOs, testroot.pristine ends up with copies of glibc-provided libraries
>> from the system because it can't overwrite or remove them.
>>
>> This patch avoids the unintended copies by executing ld.so with the same
>> arguments passed to each glibc test.
>
> The patch looks okay to me because $(rtld-prefix) is not affected by
> $(build-hardcoded-path-in-tests).  But in that case, the probing
> command is definitely not run like a test would run.

Interesting...  Current master has a couple of failures when I configured
with --enable-hardcoded-path-in-tests.
This patch doesn't break nor improve the situation there.

So, I'm pushing it.

Thanks!!

-- 
Tulio Magno



More information about the Libc-alpha mailing list