[PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]

TAMUKI Shoichi tamuki@linet.gr.jp
Fri Jan 18 14:01:00 GMT 2019


Hello Rafal,

From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH v7 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Thu, 17 Jan 2019 19:11:53 +0100 (CET)

> > In Japanese locales, strftime's alternative year format (%Ey) produces
> > the year of the current era (Japanese calendar).
> 
> As I wrote in my previous email, the term "Japanese calendar" may be
> incorrect here.

I think that (Japanese numeric era year) would be more appropriate.

> Now I can see that neither of our comments may be correct.  "%Ey" produces
> the number of the year within the current era.  It says which (numbered)
> year of the current era is now.  Is "nengo" a correct name for this?
> Should we maybe drop this parentheses completely, including its content?

Not correct, "nengo" (or "gengo") means "era name" (%EC).  So, We may
rather drop this parentheses completely.

> I don't quote the rest of your patch here as it looks correct to me,
> looking at previous comments from Zack and Paul.  Please rethink this
> minor issue in the commit message and/or maybe let's wait for Zack's
> or Paul's comment about it and it will be OK for me to commit this.

OK, I am going to rethink the minor issue including the quote issue.
I will try to match existing sentences as much as possible.

Regards,
TAMUKI Shoichi



More information about the Libc-alpha mailing list