[Patch] [Makefile] Exit if provided an incorrect argument

[Matthew Malcomson]

On 15/01/19 10:03, Florian Weimer wrote:
> * Matthew Malcomson:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>>         ;;
>>       --*)
>>         usage
>> +      exit 1
>>         ;;
>>       *)
>>         break
> I think you should add the exit to the usage function.
>
> Thanks,
> Florian

Makes sense -- thanks!
Fixed patch attached.

ChangeLog:

2019-01-15  Matthew Malcomson  <matthew.malcomson@arm.com>

	* Makefile (testrun.sh): Exit if provided incorrect arg.


--- Patch Inlined for ease of reply ----

diff --git a/Makefile b/Makefile
index b4703e4..9d76d86 100644
--- a/Makefile
+++ b/Makefile
@@ -137,6 +137,7 @@ GCONV_PATH="$${builddir}/iconvdata"
  usage () {
    echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
    echo "       $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
+  exit 1
  }

  toolname=default

-------------- next part --------------
A non-text attachment was scrubbed...
Name: testrun-help-fix.patch
Type: text/x-patch
Size: 338 bytes
Desc: testrun-help-fix.patch
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20190115/d97a2eb6/attachment.bin>