[PATCH COMMITTED] Fix a few typos in comments
Dmitry V. Levin
ldv@altlinux.org
Sat Jan 12 15:28:00 GMT 2019
On Sat, Jan 12, 2019 at 10:15:49AM -0500, Zack Weinberg wrote:
> On Sat, Jan 12, 2019 at 9:17 AM Dmitry V. Levin wrote:
> >
> > Apply the following spelling fixes:
> > $ git grep -F -l 'relevent' |
> > xargs sed -i 's/relevent/relevant/g'
>
> This kind of patch is useful and welcome, but I want to warn anyone
> who might be tempted to do something similar: after making global
> mechanical search-and-replace changes like this, you must manually
> review the diff and make sure you only changed text in comments, not
> code, and not names in comments either. It would not be appropriate,
> for instance, to "correct" the name of the function "creat".
I agree. While these spelling fixes look automatic, they were in fact
semi-automatic, and the script in the commit message was made afterwards
for better understanding, to save your time reviewing changes like this:
- argp_state_help, STATE is the relevent parsing state. FLAGS are from the
+ argp_state_help, STATE is the relevant parsing state. FLAGS are from the
--
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20190112/9dc9f936/attachment.sig>
More information about the Libc-alpha
mailing list