[PATCH] resolv: AAAA (28) is valid, no fallthrough to default

Andreas K. Hüttel dilfridge@gentoo.org
Thu Jan 10 00:17:00 GMT 2019


The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
Turns out the switch statement is missing a break, so the "T_AAAA" case
continues with "default".
---
 resolv/tst-resolv-ai_idn-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
index bb81c2ca23..61cc81b71f 100644
--- a/resolv/tst-resolv-ai_idn-common.c
+++ b/resolv/tst-resolv-ai_idn-common.c
@@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
               qname[0] };
         resolv_response_add_data (b, &addr, sizeof (addr));
       }
+      break;
     default:
       FAIL_EXIT1 ("invalid qtype: %d", qtype);
     }
-- 
2.20.1



More information about the Libc-alpha mailing list