[PATCH] Fix location where math-vector-fortran.h is installed.

Martin Liška mliska@suse.cz
Wed Feb 27 10:36:00 GMT 2019


On 2/27/19 11:12 AM, Florian Weimer wrote:
> * Martin Liška:
> 
>>          is_nonsysdep_header = os.access(header, os.R_OK)
>>          if is_nonsysdep_header:
>> +            # Skip Fortran header files
>> +            if '-*- f90 -*-' in open(header).readlines()[0]:
>> +                continue
> 
> Please use “with” to close the file promptly, and do not read the entire
> file, like this (untested):
> 
>     # Skip Fortran header files.
>     with open(header) as inp:
>         if '-*- f90 -*-' in next(inp):
>             continue

Good point. Is the patch ready to be installed now?

Thanks,
Martin

> 
> Thanks,
> Florian
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-location-where-math-vector-fortran.h-is-installe.patch
Type: text/x-patch
Size: 3374 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20190227/7f85b830/attachment.bin>


More information about the Libc-alpha mailing list