[PATCH] elf/Makefile: Run IFUNC tests if binutils supports IFUNC
Tulio Magno Quites Machado Filho
tuliom@ascii.art.br
Fri Feb 22 14:35:00 GMT 2019
"H.J. Lu" <hjl.tools@gmail.com> writes:
> We should run IFUNC tests with --disable-multi-arch if the toolchain
> supports IFUNCs. For correctness, --disable-multi-arch must not
> remove IFUNC support from the loader.
>
> Tested on x86-64, x32 and i686 with and without --disable-multi-arch.
>
> * configure.ac (have-ifunc): New LIBC_CONFIG_VAR.
> * configure: Regenerated.
> * elf/Makefile: Run IFUNC tests if binutils supports IFUNC.
We should also change this powerpc test:
diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
index bac5a3a73c..5c6ea0a95e 100644
--- a/sysdeps/powerpc/Makefile
+++ b/sysdeps/powerpc/Makefile
@@ -14,7 +14,7 @@ mod-tlsopt-powerpc.so-no-z-defs = yes
tests += tst-tlsopt-powerpc
$(objpfx)tst-tlsopt-powerpc: $(objpfx)mod-tlsopt-powerpc.so
-ifneq (no,$(multi-arch))
+ifeq (yes,$(have-ifunc))
tests-static += tst-tlsifunc-static
tests-internal += tst-tlsifunc-static
ifeq (yes,$(build-shared))
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
--
Tulio Magno
More information about the Libc-alpha
mailing list