[PATCH updated] Use a proper C tokenizer to implement the obsolete typedefs test.

[Zack Weinberg]

On Wed, Feb 20, 2019 at 11:32 AM Carlos O'Donell <carlos@redhat.com> wrote:
>
> This looks good to me.

Thanks for review.  A build-many-glibcs run found problems with
arch-specific headers which I believe I have corrected, but they
involve complex changes to the test script so I would appreciate
another round of review.  (No further changes to installed headers are
required, though.) Will post a revised patch either late tonight or
tomorrow morning, depending how long another b-m-g run takes to
complete.

> * Fix commit message to remove freeze comments.

Done.

> * Convincingly explain the gcc 2.7 testing worries I have.

I believe you have misread the patch.  There are several 'typedef int
foo_t __attribute__ ((__mode__ (bar)))' constructs currently present
in sys/types.h; my patch removes some of them.  I'm confident that it
does not introduce any new ones, and I think (but wouldn't mind a
second pair of eyes verifying that) it does not change the
preprocessor conditionals controlling the remaining ones.

I have a follow-up patch under development that removes the remaining
uses of __attribute__ ((__mode__ (xxx))).

zw