Prefer _Noreturn to __attribute__ ((__noreturn__)) when either will do

Paul Eggert eggert@cs.ucla.edu
Sat Feb 16 02:28:00 GMT 2019


Joseph Myers wrote:
> You can of course propose
> (with corresponding patch) a change to the style used

Fair enough. (That's what I get for suggesting an improvement.... :-) Proposed 
patch attached.

> (recalling that for
> installed headers _Noreturn would reduce portability because of prefix
> attributes not working with GCC 2.7),

The attached patch shouldn't reduce portability to GCC 2.7 or earlier, because 
cdefs.h defines _Noreturn to nothing for these ancient compilers, which merely 
means they may miss some minor opportunities for optimization when compiling 
user code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Prefer-_Noreturn-to-__attribute__-noreturn.patch
Type: text/x-patch
Size: 70556 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20190216/4d1874f9/attachment.bin>


More information about the Libc-alpha mailing list