[PATCH] RISC-V: Fix elfutils testsuite unwind failures.

Palmer Dabbelt palmer@sifive.com
Wed Feb 13 22:25:00 GMT 2019


On Wed, 13 Feb 2019 08:33:34 PST (-0800), schwab@suse.de wrote:
> On Jan 13 2019, Jim Wilson <jimw@sifive.com> wrote:
>
>> Unfortunately, the testcase isn't working as expected and I don't know why.
>> The testcase passes even when my clone.S patch is not installed.
>
> I don't see that here, with the current tools from openSUSE Factory.
> There many be some (bad?) luck involved, since it's undefined territory.
>
>> 	[BZ #24040]
>> 	* elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0.
>> 	* elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h
>> 	(func): New.
>> 	(main): If USE_PTHREADS, call pthread_create to run func.  Otherwise
>> 	call func directly.
>> 	* nptl/Makefile (tests): Add tst-unwind-thread.
>> 	(CFLAGS-tst-unwind-thread.c): Define.
>> 	* nptl/tst-unwind-thread.c: New file.
>> 	* sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra
>> 	as undefined.
>
> Ok.

Thanks.  I committed this.



More information about the Libc-alpha mailing list