Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives)

[Andreas Schwab]

On Jan 31 2019, Vineet Gupta <vineet.gupta1@synopsys.com> wrote:

> However what was not obvious is adjustment to
> sysdeps/<arch>/nptl/pthread-offsets.h to __PTHREAD_MUTEX_*_OFFSET. But these don't
> seem to be *actually* used anywhere. Sure there are assert checks in
> pthread_mutext_init.c but what's the point: the struct is generic anyways. IOW I'm
> not sure what port specific errors/inconsistency they are catching, other than the
> fact that they need to be hand calculating when starting a new port.
>
> Am I missing something ?

The _OFFSET macros are for ensuring binary compatibility.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."