[PATCH v3 2/3] elf: avoid redundant sort in dlopen

David Kilroy David.Kilroy@arm.com
Tue Dec 3 17:30:00 GMT 2019


l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().

Tested by running the testsuite on x86_64.
---
 elf/dl-open.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/elf/dl-open.c b/elf/dl-open.c
index 9996fe9..c4d09c7c 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -658,7 +658,6 @@ dl_open_worker (void *a)
       l = new->l_initfini[++j];
     }
   while (l != NULL);
-  _dl_sort_maps (maps, nmaps, NULL, false);
 
   int relocation_in_progress = 0;
 
-- 
2.7.4



More information about the Libc-alpha mailing list