[PATCH v2 3/4] Refactor sigcontextinfo.h
Florian Weimer
fweimer@redhat.com
Wed Aug 21 09:06:00 GMT 2019
* Adhemerval Zanella:
> diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h b/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h
> index 209a6c9dac..9569c47f79 100644
> --- a/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h
> +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h
> @@ -84,16 +84,23 @@ struct __siginfo_sparc64_fpu
> unsigned int si_fprs;
> };
>
> +/* Different that other architectures, SPARC32 pass a pt_regs (or pt_regs32
> + in 32 bits compat mode) struct pointer as third argument for sa_sigaction
> + handler with SA_SIGINFO. */
You should use “Unlike other architectures” here as well, and “passes”
“as the third argument”, as in
sysdeps/unix/sysv/linux/ia64/sigcontextinfo.h.
There is also some trailing whitespace left in the patch.
I do not have further comments on v2 of the patch.
Thanks,
Florian
More information about the Libc-alpha
mailing list