[RFC v4 07/24] time: Deprecate struct timezone members

Alistair Francis alistair23@gmail.com
Sat Aug 10 01:30:00 GMT 2019


On Fri, Aug 9, 2019 at 6:20 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
>
> Alistair Francis wrote:
> > -    int tz_minuteswest;              /* Minutes west of GMT.  */
> > -    int tz_dsttime;          /* Nonzero if DST is ever in effect.  */
> > +    int tz_minuteswest_dep;          /* Minutes west of GMT.  */
> > +    int tz_dsttime_dep;              /* Nonzero if DST is ever in effect.  */
> These two members should be declared with __attribute_deprecated__. And once we
> do that, do we still need to change their names? I don't recall any other
> instance of such name-changing.

The name changing is coming from a suggestion here [1]. I do find it a
little aggressive though as I do see some build failures, specifically
for systemd.

>
> If we do change their names, I suggest a more-obvious suffix than "_dep" (which
> could stand for a lot of things); "_deprecated" would be clearer.

I'll change the name if we still decided to stick with the name change.

1: https://sourceware.org/ml/libc-alpha/2019-07/msg00614.html

Alistair



More information about the Libc-alpha mailing list