[v1] Add Reiwa era tests to time/tst-strftime3.c

Carlos O'Donell codonell@redhat.com
Tue Apr 2 18:45:00 GMT 2019


On 4/2/19 10:41 AM, DJ Delorie wrote:
> "Carlos O'Donell" <codonell@redhat.com> writes:
>> OK for master with the following changes:
>> - Fix comments.
>> - Wait for ja_JP fix to land.
> 
> Fixed and pushed!
> 
>> Reviewed-by: Carlos O'Donell  <carlos@redhat.com>
> 
> Sigh, forgot this line again :-P
> Can we check for this in the commit hook?  ;-)
  
I think that would be *awesome* that every commit would have
a check for a Reviewed-by: line to ensure quality, and review.

We would have to talk about that in a big discussion, but
maybe I'll propose it for Cauldron.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list