Sticky EOF breaks stream concatenation via dup2 [BZ #23636]

[Rich Felker]

On Mon, Sep 17, 2018 at 11:17:20AM -0400, Carlos O'Donell wrote:
> On 09/17/2018 11:14 AM, Adam Sampson wrote:
> > Florian Weimer <fweimer@redhat.com> writes:
> > 
> >>> Getting back to the particular software broken, cups-filter, how did
> >>> it work on non-glibc systems without this bug? Was the code being used
> >>> glibc-specific? Or was it just untested elsewhere?
> >> The current dependencies of cups-filters look sufficiently heavy that
> >> it's possible that only glibc targets were used with it.
> > 
> > cups-filters is included in the FreeBSD ports collection, but they've
> > been carrying a patch since 2015 that adds clearerr(stdin); in the
> > appropriate place:
> > 
> > https://svnweb.freebsd.org/ports/head/print/cups-filters/files/patch-filter_foomatic-rip_foomaticrip.c?revision=411031&view=markup
>  
> Adam,
> 
> Thank you *very* much for chiming in. That data point is indicative
> that we may have just a few packages that fail like this.
> 
> Do you have any visibility into the ports tree to see how many
> other patches add clearerr(.*);?

Maybe getting a bit off-topic, but something is really wrong with FOSS
processes of getting fixes upstream if FreeBSD ports had this trivial
fix since 2015 and it didn't make it upstream.

Rich