On 09/12/2018 02:15 PM, Joseph Myers wrote: > +modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\ > + $(modules-names)) Perhaps add a comment that the reliance on internal headers is the reason for filtering out these module names? Patch looks fine to me otherwise. Thanks, Florian