[patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S

Florian Weimer fweimer@redhat.com
Wed Sep 12 11:59:00 GMT 2018


On 09/12/2018 01:57 PM, H.J. Lu wrote:
> On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 09/07/2018 09:06 AM, Terry Guo wrote:
>>>
>>> +       /* Clearing frame pointer is insufficient, use CFI.  */
>>> +       cfi_undefined (eip)
>>
>>
>> Isn't this a separate fix?
> 
> Since _start now includes CFI, without "cfi_undefined (eip)",  unwinder may not
> terminate at _start and one unwind test will fail.

Ah!  Please include this information in the commit message or ChangeLog 
entry, too.

Thanks,
Florian



More information about the Libc-alpha mailing list